◐ Shell
clean mode source ↗

gh-87092: move CFG related code from compile.c to flowgraph.c by iritkatriel · Pull Request #103021 · python/cpython

…ompile.c there, so they can be shared

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit abaeeac 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@iritkatriel iritkatriel changed the title gh-87092: move CFG related code from compile.c to cfg.c gh-87092: move CFG related code from compile.c to cfg_opt.c

Mar 27, 2023

@iritkatriel iritkatriel changed the title gh-87092: move CFG related code from compile.c to cfg_opt.c gh-87092: move CFG related code from compile.c to flowgraph.c

Mar 29, 2023

markshannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of duplicated code, otherwise looks fine.

I don't think _PyOpcode_RelativeJump is needed any more, as all jumps are relative.

@bedevere-bot

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

@iritkatriel

I don't think _PyOpcode_RelativeJump is needed any more, as all jumps are relative.

I agree, but I'd like to do it in a separate PR because I would need to remove usages and the diff here is large enough.

@iritkatriel

I have made the requested changes; please review again.

@bedevere-bot

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

markshannon

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023