gh-103092: Isolate _collections by erlend-aasland · Pull Request #103093 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I finished the remaining bits.
Now it crashes in the dict watcher deallocation, cc @carljm
BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on test_defaultdict.
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0dcfcef 🤖
If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0381b45 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final approval!
aisk pushed a commit to aisk/cpython that referenced this pull request
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>