◐ Shell
clean mode source ↗

gh-103092: Isolate _collections by erlend-aasland · Pull Request #103093 · python/cpython

kumaraditya303

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I finished the remaining bits.

@kumaraditya303

Now it crashes in the dict watcher deallocation, cc @carljm

@erlend-aasland

Now it crashes in the dict watcher deallocation, cc @carljm

See 45a26f3, which I believe is the correct prescription. Notice that PyDict_Type.tp_init is called explicitly from defdict_init. IIRC, that is not needed, but I may be wrong (I'm unable to check that right now).

@erlend-aasland

This comment was marked as outdated.

kumaraditya303

@erlend-aasland

BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on test_defaultdict.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0dcfcef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0381b45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@erlend-aasland

Good find! No ref.leaks locally over here.

kumaraditya303

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final approval!

@erlend-aasland

aisk pushed a commit to aisk/cpython that referenced this pull request

Apr 18, 2023
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>