◐ Shell
clean mode source ↗

gh-103124: Multiline statement support for pdb by gaogaotiantian · Pull Request #103125 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gaogaotiantian

@gaogaotiantian gaogaotiantian commented

Mar 30, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This fails one test now - the one that expects

(Pdb) print(

to fail directly. That's a behavior that the feature changes, so if we want to have this feature, we need to change the test.

@arhadthedev arhadthedev added the stdlib

Standard Library Python modules in the Lib/ directory

label

Mar 30, 2023

@arhadthedev

Copy link Copy Markdown

Member

@iritkatriel @ambv as mergers of related gh-101674 and gh-103024.

@gaogaotiantian gaogaotiantian marked this pull request as ready for review

April 9, 2023 03:55

@brandtbucher brandtbucher self-requested a review

April 28, 2023 17:49

@brandtbucher brandtbucher left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited to see this in 3.13! I'm just having a little trouble following the new logic (I believe you that it's correct, though):

Comment thread

Lib/pdb.py

Comment thread

Lib/pdb.py

@brandtbucher brandtbucher self-assigned this

Jun 15, 2023

@brandtbucher brandtbucher enabled auto-merge (squash)

June 15, 2023 23:00

@brandtbucher brandtbucher disabled auto-merge

June 15, 2023 23:00

@brandtbucher brandtbucher enabled auto-merge (squash)

June 15, 2023 23:01

@brandtbucher brandtbucher merged commit 25a64fd into python:main

Jun 15, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Jun 16, 2023
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)

gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request

Jun 18, 2023

@gaogaotiantian gaogaotiantian deleted the pdb-multiline-statement branch

May 6, 2024 19:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

Labels

stdlib

Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaogaotiantian @arhadthedev @brandtbucher @bedevere-bot