◐ Shell
clean mode source ↗

gh-83004: Harden _socket init by erlend-aasland · Pull Request #103261 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

Apr 5, 2023

edited by miss-islington

Loading

Copy link Copy Markdown

Contributor

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland

Copy link Copy Markdown

Contributor Author

See also gh-99044 for a partial hardening.

@erlend-aasland erlend-aasland added skip news 🔨 test-with-refleak-buildbots

Test PR w/ refleak buildbots; report in status section

labels

Apr 5, 2023

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0722e40 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots

Test PR w/ refleak buildbots; report in status section

label

Apr 5, 2023

@hauntsaninja hauntsaninja left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

erlend-aasland reacted with heart emoji
Comment thread

Modules/socketmodule.c Outdated

@miss-islington

Copy link Copy Markdown

Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 91794e5 into python:main

Apr 7, 2023

@erlend-aasland erlend-aasland deleted the cleanup-socket-init branch

April 8, 2023 08:13

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023
Automerge-Triggered-By: GH:erlend-aasland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @miss-islington @hauntsaninja