◐ Shell
clean mode source ↗

gh-83004: Harden winsound init by erlend-aasland · Pull Request #103385 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

Apr 8, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@hauntsaninja hauntsaninja left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Should we decref module in the error case?
erlend-aasland reacted with thumbs up emoji 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

@erlend-aasland

erlend-aasland commented

Apr 9, 2023

•

edited

Loading

Copy link Copy Markdown

Contributor Author

Thanks for the review, Kumar & Shantanu!

@erlend-aasland erlend-aasland merged commit 6d97e52 into python:main

Apr 9, 2023

@erlend-aasland erlend-aasland deleted the cleanup-winsound branch

April 9, 2023 20:00

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023

aisk pushed a commit to aisk/cpython that referenced this pull request

Apr 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @hauntsaninja @kumaraditya303 @bedevere-bot