gh-83004: Harden msvcrt further by erlend-aasland · Pull Request #103420 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
The old insert* helpers were buggy: conversion errors were cleared, insert dict errors simply ignored (could theoretically end up overwriting the previous exception over and over again).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing error label
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
missing error label
Thanks for the heads-up. I removed those gotos. PTAL.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters