gh-103438: Don't define CTYPES_PASS_BY_REF_HACK on aarch64 or riscv64 by andreas-schwab · Pull Request #103439 · python/cpython
FFY00
left a comment
•
Loading
FFY00
left a comment
•
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a comment on test_pass_by_value linking to GH-103438 and noting that it's possible the user is using an older libffi if the test is failing.
We also need a news entry documenting this change.
We should probably add a comment on
test_pass_by_valuelinking to GH-103438 and noting that it's possible the user is using an older libffi if the test is failing.We also need a news entry documenting this change.
"And older libffi" is also the version included with macOS (the current SDK headers claim to be 3.4rc1). If I understand correctly unconditionally removing this workaround would therefore break macOS builds that use the system libffi, including our own installers.