◐ Shell
clean mode source ↗

gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending by alisaifee · Pull Request #103463 · python/cpython

Includes two failing tests that demonstrate a bug
where if the data passed to writelines can't be sent
in one shot, the remaining buffer isn't written since
there is no registered write handler
If all the data in the buffer can't be written immediately
schedule a writer to handle the remaining data.

@bedevere-bot

@ghost

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

@alisaifee alisaifee changed the title gh-103462: Ensure SelectorSocketTransport.writelines schedules a writer when data is still pending gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending

Apr 12, 2023
When the platform (windows) doesn't support it
skip tests for writelines using sendmsg

@bedevere-bot

kumaraditya303

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you add a news entry? Thanks

@alisaifee

LGTM, Can you add a news entry? Thanks

done!

kumaraditya303

kumaraditya303

carljm added a commit to carljm/cpython that referenced this pull request

Apr 13, 2023

aisk pushed a commit to aisk/cpython that referenced this pull request

Apr 18, 2023