GH-103517: Improve tests for `pathlib.Path.walk()` by barneygale · Pull Request #103518 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
Remove list index juggling from tests for pathlib.Path.walk(top_down=True) and walk(top_down=False), which makes them more readable.
We no longer check the order that sibling directories are visited in bottom-up mode. This order is arbitrary and cannot be controlled by the user.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how you have rewritten them. Lack of indexes really does make them much more readable.
Sadly, I have no suggestions as I feel like your work here is complete as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters