gh-103538: Remove unused TK_AQUA code by chrstphrchvz · Pull Request #103539 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Contributor
bedevere-bot
commented
Apr 14, 2023
bedevere-bot commented
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
arhadthedev
added
stdlib
topic-tkinter skip news OS-mac labels
chrstphrchvz
force-pushed
the
patch-103538
branch
from
c035fc2 to
92529ee
Compare
zware
removed
the
skip news
label
zware
approved these changes
zware
left a comment
zware
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I realized shortly after merging GH-103535 that it really ought to have a news entry after all, and this one should too. There's a near-0 chance that anyone is actually using these macros for anything, but we should note that they're gone in any case.
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
chrstphrchvz
force-pushed
the
patch-103538
branch
2 times, most recently
from
e610fef to
758459d
Compare
chrstphrchvz
commented
Apr 14, 2023
chrstphrchvz commented
Contributor Author
Is a 2-item ordered list too much for a blurb?
chrstphrchvz
force-pushed
the
patch-103538
branch
2 times, most recently
from
6e7adbe to
9a7cc13
Compare
zware
reviewed
Misc/NEWS.d/next/Library/2023-04-14-21-12-32.gh-issue-103538.M4FK_v.rst Outdated
chrstphrchvz and others added 3 commits
zware
force-pushed
the
patch-103538
branch
from
7e1a688 to
bd45b97
Compare
zware
enabled auto-merge (squash)
zware
merged commit
e464ec9
into
python:main
bedevere-bot
removed
the
awaiting merge
label
chrstphrchvz
deleted the
patch-103538
branch
carljm added a commit to carljm/cpython that referenced this pull request
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
carljm added a commit to carljm/cpython that referenced this pull request
* main: (27 commits) pythongh-87849: fix SEND specialization family definition (pythonGH-104268) pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384) pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367) pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369) pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383) pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287) pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185) pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368) pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141) pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment