◐ Shell
clean mode source ↗

gh-101100: Add reference doc for __post_init__ by olgarithms · Pull Request #103818 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

carljm

merged 1 commit into

python:mainfrom

olgarithms:fix-issue-101100

Apr 28, 2023

Merged

gh-101100: Add reference doc for __post_init__#103818

carljm

merged 1 commit into

python:mainfrom

olgarithms:fix-issue-101100

Conversation

@olgarithms

@olgarithms olgarithms commented

Apr 25, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Continuing from #103811, @CAM-Gerlach advised we add a clear reference to __post_init__.

Signed-off-by: Olga Matoula <olgamatoula@gmail.com>

@CAM-Gerlach CAM-Gerlach left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @olgarithms ! I'll leave it to @carljm or Eric to approve and merge

@carljm carljm left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the contribution!

hugovk reacted with hooray emoji hugovk reacted with rocket emoji

@carljm carljm merged commit 83aa496 into python:main

Apr 28, 2023

@olgarithms olgarithms deleted the fix-issue-101100 branch

May 15, 2023 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olgarithms @carljm @CAM-Gerlach @bedevere-bot