◐ Shell
clean mode source ↗

gh-103583: Isolate CJK modules, alternative 1 by erlend-aasland · Pull Request #103868 · python/cpython

erlend-aasland

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

Apr 26, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@erlend-aasland

Copy link Copy Markdown

Contributor Author

This approach alters the semantics of the codec config pointer. It works, but it is very hacky (IMO). In short, I don't like this approach. I do not recommend it. But it works.

@erlend-aasland

Copy link Copy Markdown

Contributor Author

Closing in favour of #103869

@erlend-aasland erlend-aasland deleted the isolate-cjk-alt1 branch

April 26, 2023 18:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland @bedevere-bot