gh-87092: change assembler to use instruction sequence instead of CFG by iritkatriel · Pull Request #103933 · python/cpython
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Comment on lines -6971 to -6974
| if (cfg_to_instr_sequence(&g, &optimized_instrs) < 0) { | ||
| goto error; | ||
| } | ||
|
|
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we were previously doing this twice? Was that intentional?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not intentional, slipped through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters