◐ Shell
clean mode source ↗

gh-84436 Add integration C API tests for immortal objects by corona10 · Pull Request #103962 · python/cpython

Conversation

corona10

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look on my phone. I'll take a better look later today.

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments on test_immortal_bool. The same comments applies to the rest of the test functions.

@JelleZijlstra JelleZijlstra changed the title gh-84436 Add intergration C API tests for immortal objects gh-84436 Add integration C API tests for immortal objects

Apr 29, 2023

@corona10

erlend-aasland

@corona10

Merge this PR. If there needs some improvement, please let me know!

carljm added a commit to carljm/cpython that referenced this pull request

May 2, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 2, 2023

Labels