◐ Shell
clean mode source ↗

gh-103824: fix use-after-free error in Parser/tokenizer.c by chgnrdv · Pull Request #103993 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

pablogsal

merged 5 commits into

python:mainfrom

chgnrdv:fix-tokenizer-use-after-free

May 1, 2023

Merged

gh-103824: fix use-after-free error in Parser/tokenizer.c#103993

pablogsal

merged 5 commits into

python:mainfrom

chgnrdv:fix-tokenizer-use-after-free

Conversation

@chgnrdv

@chgnrdv chgnrdv commented

Apr 29, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fixes use-after-free errors in tokenizer.c that are mentioned in #103824.

`tok_get_fstring_mode`: ensure that token in the f-string middle is properly decoded, i.e. `tok_nextc` doesn't return EOF with `tok->decoding_erred` set to 1

@arhadthedev arhadthedev added the interpreter-core

(Objects, Python, Grammar, and Parser dirs)

label

Apr 29, 2023

@chgnrdv chgnrdv marked this pull request as ready for review

April 30, 2023 09:35

@pablogsal pablogsal enabled auto-merge (squash)

May 1, 2023 07:58

@pablogsal pablogsal merged commit d5a9707 into python:main

May 1, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 1, 2023
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chgnrdv @pablogsal @arhadthedev @bedevere-bot