GH-103963: Make dis display names of args for intrinsics opcodes by jkchandalia · Pull Request #104029 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few comments. You'll also have to add a NEWS entry.
@iritkatriel @JelleZijlstra I've reviewed your comments and updated the PR. Please let me know if you see anything else or if I should convert to normal PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'll give Irit some time to take another look, but I think this is ready to merge.
|
|
||
|
|
||
| /* Binary Functions: */ | ||
| #define INTRINSIC_INVALID 0 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like INTRINSIC_INVALID is defined twice?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to differentiate between invalid for the two CALL_INTRINSIC_* opcodes.