◐ Shell
clean mode source ↗

gh-104057: Fix direct invocation of test_module by Eclips4 · Pull Request #104059 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

zware

merged 1 commit into

May 1, 2023

Conversation

@Eclips4

@Eclips4 Eclips4 changed the title Fix direct invocation of test_module gh-104057: Fix direct invocation of test_module

May 1, 2023

zware

@zware zware enabled auto-merge (squash)

May 1, 2023 19:53

@Eclips4

Hello @zware!
Should it be backported to 3.11 branch?

@Eclips4

Also, I found an few similiar issues in tests.
Should I create an new issue for each of them?
I would create a one issue and just mention it in PR's.

@AlexWaygood

Using one issue and linking multiple PRs to it would be best.

@Eclips4

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex!
Should I create new issue, or just rename #104057 ?

@miss-islington

Thanks @Eclips4 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

Sorry, @Eclips4 and @zware, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d448fcb0323bf00cb4ff4a1e65e8424a73b5f0d4 3.11

@zware

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex! Should I create new issue, or just rename #104057 ?

I'll reopen and rename #104057.

@zware

Hello @zware! Should it be backported to 3.11 branch?

Apparently not :). That line doesn't exist in 3.11; if there's a similar issue in that branch, we should just create a clean PR against 3.11.

@AlexWaygood

Apparently not :). That line doesn't exist in 3.11

Oops, sorry 'bout that! I should have checked before adding the label.

carljm added a commit to carljm/cpython that referenced this pull request

May 1, 2023

Labels