◐ Shell clean mode source ↗

gh-103323: Remove PyRuntimeState_GetThreadState() by vstinner · Pull Request #104171 · python/cpython

vstinner

Skip to content

Merged

merged 1 commit into

python:mainfrom

vstinner:remove_rt_get_tstate

May 4, 2023

Merged

gh-103323: Remove PyRuntimeState_GetThreadState()#104171
vstinner
merged 1 commit into
python:mainfrom
vstinner:remove_rt_get_tstate

Conversation

vstinner commented
May 4, 2023
•

edited by bedevere-bot

Loading

Copy link

Copy Markdown

Member

This function no longer makes sense, since its runtime parameter is no longer used. Use directly _PyThreadState_GET() and _PyInterpreterState_GET() instead.

Issue: Get the "Current" Thread State from a Thread-local #103323

pythongh-103323: Remove PyRuntimeState_GetThreadState()

This function no longer makes sense, since its runtime parameter is
no longer used. Use directly _PyThreadState_GET() and
_PyInterpreterState_GET() instead.

vstinner added the skip news label

bedevere-bot mentioned this pull request

Get the "Current" Thread State from a Thread-local #103323

Closed

bedevere-bot added awaiting core review labels

vstinner mentioned this pull request

gh-103323: Get the "Current" Thread State from a Thread-Local Variable #103324

Merged

vstinner commented
May 4, 2023

Copy link

Copy Markdown

Member Author

cc @ericsnowcurrently

ericsnowcurrently approved these changes May 4, 2023

View reviewed changes

ericsnowcurrently left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bedevere-bot added awaiting merge and removed awaiting core review labels

vstinner merged commit 45398ad into python:main

vstinner deleted the remove_rt_get_tstate branch

May 4, 2023 14:21

bedevere-bot removed the awaiting merge label

vstinner commented
May 4, 2023

Copy link

Copy Markdown

Member Author

Merged, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants