◐ Shell
clean mode source ↗

gh-64658: Expand Argument Clinic return converter docs by erlend-aasland · Pull Request #104175 · python/cpython

erlend-aasland

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only understand AC in the vaguest terms, but that is definitely a sentence that makes grammatical sense! :)

@erlend-aasland

This comment was marked as outdated.

@erlend-aasland erlend-aasland changed the title gh-64658: Amend Argument Clinic return converter docs gh-64658: Expand Argument Clinic return converter docs

May 4, 2023

@erlend-aasland

BTW, I removed the reference to the init converter; it's only used internally by AC anyways.

@erlend-aasland

FTR, I'm landing this soon. We can easily fix nitpicks in the docs later (no issue needed).

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, but I still feel like a very underqualified reviewer here :)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

erlend-aasland

@bedevere-bot

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

May 5, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 5, 2023

jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request

May 8, 2023

erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request

Sep 8, 2023

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request

Sep 13, 2023

erlend-aasland added a commit to python/devguide that referenced this pull request

Sep 26, 2023