◐ Shell
clean mode source ↗

gh-101819: Harden _io init by erlend-aasland · Pull Request #104352 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

Fix potential refleak if PyModule_AddObject() fails

kumaraditya303

carljm added a commit to carljm/cpython that referenced this pull request

May 10, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 11, 2023

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyModule_AddObject() is really hard to use correctly. I strongly prefer PyModule_AddObjectRef() that I added to fix my own mistakes :-)

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post merge review: LGTM.

Labels