gh-104371: Fix calls to __release_buffer__ while an exception is active by JelleZijlstra · Pull Request #104378 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Member
kumaraditya303
requested changes
Objects/typeobject.c Outdated
Objects/typeobject.c Outdated
bedevere-bot
commented
May 11, 2023
bedevere-bot commented
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
JelleZijlstra
commented
May 12, 2023
JelleZijlstra commented
Member Author
Thanks for the review @kumaraditya303!
I have made the requested changes; please review again.
bedevere-bot
commented
May 12, 2023
bedevere-bot commented
Thanks for making the requested changes!
@kumaraditya303: please review the changes made to this pull request.
kumaraditya303
approved these changes
a0a98dd
into
python:main
markshannon
reviewed
markshannon
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix doesn't appear to be correct.
carljm added a commit to carljm/cpython that referenced this pull request
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
