◐ Shell
clean mode source ↗

gh-101819: Fix inverted debug preprocessor check in winconsoleio.c by erlend-aasland · Pull Request #104388 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented

May 11, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland enabled auto-merge (squash)

May 11, 2023 12:58

@erlend-aasland erlend-aasland merged commit ddc0e70 into python:main

May 11, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 11, 2023
* main:
  pythongh-104057: Fix direct invocation of test_support (pythonGH-104069)
  pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270)
  pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)

@erlend-aasland erlend-aasland deleted the isolate-io/address-reviews branch

May 21, 2023 21:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland @vstinner @bedevere-bot