◐ Shell
clean mode source ↗

gh-104469 Convert _testcapi/float.c to use AC by corona10 · Pull Request #104470 · python/cpython

@corona10 corona10 marked this pull request as ready for review

May 14, 2023 09:05

@corona10

This is the sample PR and also for the 1st PR but if the #104469 is rejected, I will close the PR.

sobolevn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! From my point of view, this is indeed an improvement 👍

@corona10

LGTM! From my point of view, this is indeed an improvement 👍

Thank you, let's wait for @erlend-aasland 's opinion too.
He is AC expert these days, and I also expect feedback which kinds of things are not to be converted.

@AlexWaygood AlexWaygood changed the title gh-104469 Convert _testcapi/flaot.c to use AC gh-104469 Convert _testcapi/float.c to use AC

May 14, 2023

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Less boilerplate code in the tests is a good thing IMO.

carljm added a commit to carljm/cpython that referenced this pull request

May 15, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 15, 2023