gh-104469 Convert _testcapi/float.c to use AC by corona10 · Pull Request #104470 · python/cpython
corona10
marked this pull request as ready for review
This is the sample PR and also for the 1st PR but if the #104469 is rejected, I will close the PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! From my point of view, this is indeed an improvement 👍
LGTM! From my point of view, this is indeed an improvement 👍
Thank you, let's wait for @erlend-aasland 's opinion too.
He is AC expert these days, and I also expect feedback which kinds of things are not to be converted.
AlexWaygood
changed the title
gh-104469 Convert _testcapi/flaot.c to use AC
gh-104469 Convert _testcapi/float.c to use AC
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice. Less boilerplate code in the tests is a good thing IMO.