gh-104469: Convert _testcapi/watchers.c to use AC by sobolevn · Pull Request #104503 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Member
Skipping news, because there are not use-facing changes.
CC @corona10 @erlend-aasland
sobolevn
commented
May 15, 2023
sobolevn commented
Member Author
As far as I know, Test Hypothesis failure is not related
Modules/_testcapi/watchers.c Outdated
erlend-aasland
commented
May 15, 2023
erlend-aasland commented
Contributor
Also, remember to make clinic before pushing.
erlend-aasland
commented
May 15, 2023
erlend-aasland commented
Contributor
BTW, the rest of the tests should be cancelled if "Check if generated files are up to date" fails. CC. GitHub wizard @hugovk.
Member
"Check for source changes" is a gating step, but "Check if generated files are up to date" isn't:
https://github.com/python/cpython/actions/runs/4980218331?pr=104503
This is how the other steps depend on "Check four source changes" in https://github.com/python/cpython/blob/b378d991f8cd41c33416e590cb83472cce1d6b98/.github/workflows/build.yml:
needs: check_source if: needs.check_source.outputs.run_tests == 'true'
corona10
reviewed
corona10
reviewed
corona10
reviewed
erlend-aasland
approved these changes
456d566
into
python:main
carljm added a commit to carljm/cpython that referenced this pull request
* main: pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) pythongh-64595: Fix write file logic in Argument Clinic (python#104507) pythongh-104523: Inline minimal PGO rules (python#104524) pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863) pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248) pythongh-103763: Implement PEP 695 (python#103764) pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462) pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503) pythongh-104482: Fix error handling bugs in ast.c (python#104483) pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437) pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
