◐ Shell
clean mode source ↗

GH-103092: isolate `pyexpat` by kumaraditya303 · Pull Request #104506 · python/cpython

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the template buffer spelled out, it would be nice to move it out of the C function for the sake of readability.

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review: LGTM!

carljm added a commit to carljm/cpython that referenced this pull request

May 17, 2023