◐ Shell
clean mode source ↗

GH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline. by markshannon · Pull Request #104579 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@markshannon

@markshannon markshannon commented

May 17, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

And leave adding the frame to the traceback to the interpreter.

…e-102818.rnv1mH.rst

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

@markshannon markshannon merged commit c26d03d into python:main

May 19, 2023

@markshannon markshannon added the needs backport to 3.11

only security fixes

label

May 19, 2023

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

Copy link Copy Markdown

Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c26d03d5d6da94367c7f9cd93185616f2385db30 3.11

carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this pull request

May 20, 2023
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...

@markshannon markshannon deleted the missing-frame-settrace-c-api branch

September 26, 2023 12:53

@ZeroIntensity ZeroIntensity removed the needs backport to 3.11

only security fixes

label

Feb 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @miss-islington @iritkatriel @bedevere-bot @ZeroIntensity