[3.11] Fix test_importlib.test_side_effect_import() (GH-104840) by miss-islington · Pull Request #104843 · python/cpython
Conversation
Wait until the thread spawn by the import completes to avoid dangling
threads. With this fix, the following command no longer fails:
./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20
(cherry picked from commit 4269509)
Co-authored-by: Victor Stinner vstinner@python.org
Wait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails: ./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20 (cherry picked from commit 4269509) Co-authored-by: Victor Stinner <vstinner@python.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
@vstinner did you leave this open on purpose or forget the auto-merge label?
@vstinner did you leave this open on purpose or forget the auto-merge label?
There is no auto-merge label anymore (and miss-islington no longer merges any PRs herself). There is now only GitHub automerge.
@vstinner did you leave this open on purpose or forget the auto-merge label?
In the past, approving a backport PR was enough to merge a backport. It seems like I have to update my habits to add the auto-merge label.
There is now only GitHub automerge.
Oh right, I don't see any "auto-merge" label. And right now, I can only "Squash and merge", there is no "auto merge" button. Maybe it's because the CI completed successfully.
Well, I clicked on Merge manually. It's merged :-)