gh-104825: Remove implicit newline in the line attribute in tokens emitted in the tokenize module by pablogsal · Pull Request #104846 · python/cpython

pablogsal

Conversation

Issue: Token lines in the tokenize module always end in new line #104825

…ens emitted in the tokenize module

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c8cf9b42eb2bfbd4c3e708ec28d32430248a1d7a 3.12

pablogsal added a commit to pablogsal/cpython that referenced this pull request

May 24, 2023

… in tokens emitted in the tokenize module (pythonGH-104846).

(cherry picked from commit c8cf9b4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

pablogsal added a commit that referenced this pull request

May 24, 2023

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Sorry, @pablogsal, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c8cf9b42eb2bfbd4c3e708ec28d32430248a1d7a 3.11

I backported the test to 3.11 so I thought it would need this fix, but now I realize that 3.11 still has the old tokenizer, for which the patch is correct as it (tested). Sorry for the noise. But see #104850 (comment)