gh-104873: Add typing.get_protocol_members and typing.is_protocol by JelleZijlstra · Pull Request #104878 · python/cpython
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
gh-104873: Add typing.get_protocol_members
gh-104873: Add typing.get_protocol_members and typing.is_protocol
I didn't expect the Spanish inquisition!
Nobody expects the Spanish Inquisition!
@AlexWaygood: please review the changes made to this pull request.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I also just emailed typing-sig about this to ask for feedback.
Nobody spoke up against this on typing-sig, time to merge?
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to merge, in my opinion!