◐ Shell
clean mode source ↗

gh-104786: Remove kwargs-based TypedDict creation by tomasr8 · Pull Request #104891 · python/cpython

@tomasr8

Not sure if/how I should update the docs:

.. deprecated-removed:: 3.11 3.13
The keyword-argument syntax is deprecated in 3.11 and will be removed
in 3.13. It may also be unsupported by static type checkers.

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexWaygood

Not sure if/how I should update the docs:

I would remove the existing deprecated-removed note, and add something like:

.. versionchanged:: 3.13
   Removed support for the keyword-argument method of creating ``TypeDict``\s.

AlexWaygood

AlexWaygood

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood

JelleZijlstra

AlexWaygood

AlexWaygood

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks @tomasr8!

JelleZijlstra

@tomasr8 tomasr8 deleted the typeddict-kwargs-removal branch

May 25, 2023 20:18

@tomasr8