◐ Shell
clean mode source ↗

bpo-35230: dict: Remove some macros by methane · Pull Request #10513 · python/cpython

Conversation

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike "bpo-35230: Remove _Py_REF_DEBUG_COMMA" title, IMHO the main change is that PyDictKeys incref/decref macros are converted to static inline functions. The removal of _Py_REF_DEBUG_COMMA is more a side effect. Even if I know that your goal was to remove _Py_REF_DEBUG_COMMA :-)

vstinner

@methane methane changed the title bpo-35230: Remove _Py_REF_DEBUG_COMMA bpo-35230: dict: Remove some macros

Nov 14, 2018

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Labels