GH-104584: Assorted fixes for the optimizer API. by markshannon · Pull Request #105683 · python/cpython
Conversation
markshannon added 7 commits
bedevere-bot
added
the
awaiting core review
label
bedevere-bot
mentioned this pull request
markshannon
added
the
skip news
label
carljm
reviewed
Lib/test/test_capi/test_misc.py Outdated
Lib/test/test_capi/test_misc.py Outdated
Lib/test/test_capi/test_misc.py Outdated
Python/bytecodes.c Outdated
brandtbucher
self-requested a review
brandtbucher
left a comment
brandtbucher
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to all of @carljm's comments.
Objects/codeobject.c Outdated
Python/optimizer.c Outdated
Python/optimizer.c Outdated
markshannon added 2 commits
carljm
approved these changes
Lib/test/test_capi/test_misc.py Outdated
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
gvanrossum
commented
Jun 18, 2023
gvanrossum commented
Member
What's holding this up? I was playing around with the optimizer, trying to bootstrap a "hello world" version of a Tier 2 interpreter, and I need this to avoid crashes at exit (crashes that happened even without my changes).
markshannon
merged commit
5816199
into
python:main
bedevere-bot
removed
the
awaiting merge
label
markshannon
deleted the
fix-optimizer-api
branch
AlexWaygood
mentioned this pull request
erlend-aasland
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment