◐ Shell
clean mode source ↗

GH-104584: Assorted fixes for the optimizer API. by markshannon · Pull Request #105683 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented

Jun 12, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Fixes a few odds and ends found trying to fix #105682

Comment thread

Lib/test/test_capi/test_misc.py Outdated

Comment thread

Lib/test/test_capi/test_misc.py Outdated

Comment thread

Lib/test/test_capi/test_misc.py Outdated

Comment thread

Python/bytecodes.c

Comment thread

Python/bytecodes.c Outdated

@brandtbucher brandtbucher self-requested a review

June 12, 2023 17:25

@brandtbucher brandtbucher left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to all of @carljm's comments.

Comment thread

Objects/codeobject.c Outdated

Comment thread

Python/optimizer.c Outdated

Comment thread

Python/optimizer.c

Comment thread

Python/optimizer.c Outdated

@gvanrossum

Copy link Copy Markdown

Member

What's holding this up? I was playing around with the optimizer, trying to bootstrap a "hello world" version of a Tier 2 interpreter, and I need this to avoid crashes at exit (crashes that happened even without my changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

@carljm carljm carljm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

./python -m test -v test_capi -m test_misc --forever fails.

5 participants

@markshannon @gvanrossum @carljm @brandtbucher @bedevere-bot