◐ Shell
clean mode source ↗

[3.12] gh-98040: Fix importbench: use types.ModuleType() (GH-105743) by miss-islington · Pull Request #105754 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Jun 13, 2023

edited by github-actions Bot

Loading

Copy link Copy Markdown

Contributor

Replace removed imp.new_module(name) with types.ModuleType(name).
(cherry picked from commit 457a459)

Co-authored-by: Victor Stinner vstinner@python.org


📚 Documentation preview 📚: https://cpython-previews--105754.org.readthedocs.build/

)

Replace removed imp.new_module(name) with types.ModuleType(name).
(cherry picked from commit 457a459)

Co-authored-by: Victor Stinner <vstinner@python.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington @vstinner @bedevere-bot