◐ Shell
clean mode source ↗

GH-105793: Add follow_symlinks argument to `pathlib.Path.is_dir()` and `is_file()` by barneygale · Pull Request #105794 · python/cpython

barneygale

Conversation

Brings `pathlib.Path.is_dir()` in line with `os.DirEntry.is_dir()`, which
will be important for implementing generic path walking and globbing.

@barneygale barneygale changed the title GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() and is_file()

Jun 15, 2023

EpicWink

@barneygale

@zooba would you be up for reviewing this? It's similar to #102616, and necessary for a pathlib.AbstractPath or tarfile.TarPath to support globbing. Thank you, no worries if not!

zooba

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Labels