gh-105481: remove HAS_ARG, HAS_CONST, IS_JUMP_OPCODE, IS_PSEUDO_OPCODE and replace by their new versions by iritkatriel · Pull Request #105865 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Member
iritkatriel added 5 commits
gvanrossum
approved these changes
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need any doc update for dis.stack_effect (or is it opcode.stack_effect now that it no longer requires the presence of oparg to match the requirements of the opcode.
iritkatriel
commented
Jun 16, 2023
iritkatriel commented
Member Author
The doc doesn't mention the arg check issue. Should I add a versionchanged note anyway?
gvanrossum
commented
Jun 17, 2023
gvanrossum commented
Member
Might as well.
and removed skip news labels
arhadthedev
reviewed
Misc/NEWS.d/next/Library/2023-06-17-12-13-57.gh-issue-105481.KgBH5w.rst Outdated
gvanrossum
approved these changes
14d0126
into
python:main
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request
…_OPCODE and replace by their new versions (python#105865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants
