gh-105879: Add support for keyword arguments to eval and exec by rtpg · Pull Request #105885 · python/cpython
Conversation
All commit authors signed the Contributor License Agreement.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting and adding this feature! I've definitely confused the ordering of these before :-) This looks good to me (although I think I still have a vague preference for keeping the source argument positional-only)
Does this need a doc change?
@iritkatriel i believe that the docstring changes (derived from the arg clinic changes) are sufficient, as I did not see anything being explicit about positional-only-ness beyond that
I fixed the (trivial) merge conflict, undid an unnecessary formatting change, and added a documentation note as @iritkatriel suggested. I'll merge the PR in a bit so we can get this change into 3.13.
Thinking about it again I agree with @hauntsaninja's suggestion above that we should leave the first argument positional-only. I'll make that change.
SonicField pushed a commit to SonicField/cpython that referenced this pull request
…ython#105885) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>