◐ Shell
clean mode source ↗

GH-89812: Make symlink support configurable in pathlib tests. by barneygale · Pull Request #106060 · python/cpython

barneygale

Conversation

@barneygale

Adjust the pathlib tests to add a new PathTest.can_symlink class attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add an AbstractPath class; its tests will hard-code the value to True or False depending on a stub subclass's capabilities.

 
Adjust the pathlib tests to add a new `PathTest.can_symlink` class
attribute, which allows us to enable or disable symlink support in tests.
A (near-)future commit will add an `AbstractPath` class; its tests will
hard-code the value to `True` or `False` depending on a stub subclass's
capabilities.

CAM-Gerlach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but the change seems reasonable, motivated and straightforward to me, and I didn't spot any obvious issues with the implementation reading through it.

@CAM-Gerlach

You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows).

@barneygale

You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows).

Good idea! How do I do that? :)

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @barneygale for commit f9bdd3a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Labels