GH-104584: Fix `ENTER_EXECUTOR` by markshannon · Pull Request #106141 · python/cpython
Conversation
Ensure that the eval-breaker is checked and frame->prev_instr updated before entering executors.
No test changes, or news, as there doesn't seem a way to show that anything is broken.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The block headed by // Equivalent to CHECK_EVAL_BREAKER() in _PyUopExecute() towards the end of ceval.c can now also safely be replaced with a call to CHECK_EVAL_BREAKER().
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta merge (the dreaded make regen-cases), otherwise LGTM. I could use this for one of my further UOP PRs.
Can you merge this? Or are you planning to run buildbots first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters