gh-106145: Make `end_{lineno,col_offset}` required on `type_param` nodes by sobolevn · Pull Request #106224 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Member
I've also added test_type_alias.py to test_unparse to make sure that this new syntax works correctly with ast.unparse.
sobolevn
requested a review
from JelleZijlstra
sobolevn
requested review from
lysnikolaou and
pablogsal
as code owners
bedevere-bot
added
the
awaiting review
label
bedevere-bot
mentioned this pull request
lysnikolaou
approved these changes
lysnikolaou
left a comment
lysnikolaou
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Lib/test/test_unparse.py Outdated
JelleZijlstra
self-assigned this
JelleZijlstra
enabled auto-merge (squash)
JelleZijlstra
merged commit
46c1097
into
python:main
bedevere-bot
removed
the
awaiting merge
label
miss-islington
commented
Jun 30, 2023
miss-islington commented
Contributor
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
…am` nodes (pythonGH-106224) (cherry picked from commit 46c1097) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
bedevere-bot
commented
Jun 30, 2023
bedevere-bot commented
GH-106295 is a backport of this pull request to the 3.12 branch.
JelleZijlstra pushed a commit that referenced this pull request
manosriram pushed a commit to manosriram/cpython that referenced this pull request
jacobtylerwalls added a commit to jacobtylerwalls/typeshed that referenced this pull request
jacobtylerwalls
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment