◐ Shell
clean mode source ↗

gh-106145: Make `end_{lineno,col_offset}` required on `type_param` nodes by sobolevn · Pull Request #106224 · python/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106145: Make end_{lineno,col_offset} required on type_param nodes #106224

Changes from all commits

Commits

File filter

Filter by extension

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view
Diff view

2 changes: 1 addition & 1 deletion Lib/test/test_unparse.py

Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ class DirectoryTestCase(ASTTestCase):
test_directories = (lib_dir, lib_dir / "test")
run_always_files = {"test_grammar.py", "test_syntax.py", "test_compile.py",
"test_ast.py", "test_asdl_parser.py", "test_fstring.py",
"test_patma.py"}
"test_patma.py", "test_type_alias.py", "test_type_params.py"}

_files_to_test = None

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Make ``end_lineno`` and ``end_col_offset`` required on ``type_param`` ast
nodes.

2 changes: 1 addition & 1 deletion Parser/Python.asdl

Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,5 @@ module Python
type_param = TypeVar(identifier name, expr? bound)
| ParamSpec(identifier name)
| TypeVarTuple(identifier name)
attributes (int lineno, int col_offset, int? end_lineno, int? end_col_offset)
attributes (int lineno, int col_offset, int end_lineno, int end_col_offset)
}

18 changes: 6 additions & 12 deletions Python/Python-ast.c