gh-104469 Convert_testcapi/vectorcall.c to use AC by littlebutt · Pull Request #106557 · python/cpython
All commit authors signed the Contributor License Agreement.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.
I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.
Well, I am okay with it. We already did.
#104720
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thing, method names are wrong.
Please change method names and then executing the make clinic
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyobject_fastcalldict |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| _testcapi.test_pyobject_fastcalldict | |
| _testcapi.pyobject_fastcalldict |
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyobject_vectorcall |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| _testcapi.test_pyobject_vectorcall | |
| _testcapi.pyvectorcall_call |
| _testcapi.test_pyobject_vectorcall | ||
| func: object | ||
| func_args: object | ||
| kwnames: object = NULL |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| kwnames: object = NULL | |
| kwnames: object = None |
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyvectorcall_call |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| _testcapi.test_pyvectorcall_call | |
| _testcapi.pyvectorcall_call |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.
@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.
According to CI, it looks not, did you rebuild the code?
@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.
According to CI, it looks not, did you rebuild the code?
No, I didn't. I just ran rt.bat -q test_capi directly after generating .c.h file😂. Thank you for help and I learnt a lot.
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm