◐ Shell
clean mode source ↗

GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE by markshannon · Pull Request #106599 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented

Jul 10, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this should work with gh-106551 once that's ready.

@gvanrossum

gvanrossum commented

Jul 10, 2023

edited

Loading

Copy link Copy Markdown

Member

FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for except*...

@gvanrossum

Copy link Copy Markdown

Member

I pushed merge (since the conflict was my fault) but I'll leave it to you to land.

@markshannon markshannon merged commit c0c041a into python:main

Jul 11, 2023

@markshannon markshannon deleted the micro-op-jump-if-none branch

August 6, 2024 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon @gvanrossum @bedevere-bot