GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE by markshannon · Pull Request #106599 · python/cpython
Conversation
Member
Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.
markshannon added 2 commits
markshannon
added
the
skip news
label
markshannon
requested a review
from gvanrossum
bedevere-bot
added
the
awaiting core review
label
bedevere-bot
mentioned this pull request
11 tasks
gvanrossum
approved these changes
gvanrossum
left a comment
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this should work with gh-106551 once that's ready.
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
Member
FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for except*...
gvanrossum
commented
Jul 10, 2023
gvanrossum commented
Member
I pushed merge (since the conflict was my fault) but I'll leave it to you to land.
markshannon
merged commit
c0c041a
into
python:main
bedevere-bot
removed
the
awaiting merge
label
markshannon
deleted the
micro-op-jump-if-none
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment