◐ Shell
clean mode source ↗

gh-105481: expose opcode metadata via the _opcode module by iritkatriel · Pull Request #106688 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@iritkatriel

@iritkatriel iritkatriel commented

Jul 12, 2023

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@iritkatriel iritkatriel marked this pull request as draft

July 12, 2023 20:40

@iritkatriel

Copy link Copy Markdown

Member Author

There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow.

@iritkatriel iritkatriel marked this pull request as ready for review

July 14, 2023 14:39

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!

@iritkatriel

Copy link Copy Markdown

Member Author

Yes, I didn't want to expose the bitmap implementation.
gvanrossum reacted with thumbs up emoji

@iritkatriel iritkatriel merged commit 6a70edf into python:main

Jul 14, 2023

@iritkatriel iritkatriel deleted the expose_metadata branch

July 25, 2023 18:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @gvanrossum @bedevere-bot