◐ Shell
clean mode source ↗

bpo-33954: Fix compiler warning in _PyUnicode_FastFill() by vstinner · Pull Request #10737 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:masterfrom

vstinner:fix_fill_warning

Nov 27, 2018

Merged

bpo-33954: Fix compiler warning in _PyUnicode_FastFill()#10737

vstinner

merged 1 commit into

python:masterfrom

vstinner:fix_fill_warning

Conversation

@vstinner

@vstinner vstinner commented

Nov 27, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

'data' argument of unicode_fill() is modified, so it must not be
const.

Add more assertions to unicode_fill(): check the maximum character
value.

https://bugs.python.org/issue33954

'data' argument of unicode_fill() is modified, so it must not be
const.

Add more assertions to unicode_fill(): check the maximum character
value.

@vstinner vstinner merged commit 163403a into python:master

Nov 27, 2018

@vstinner vstinner deleted the fix_fill_warning branch

November 27, 2018 11:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot