◐ Shell
clean mode source ↗

GH-104580: Put `eval_breaker` back at the start of the interpreter state. by markshannon · Pull Request #107383 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented

Jul 28, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Move the eval_breaker back to the start of interpreter state.

People seem to like moving this field, so I've added comments explaining why it should be the first field in the interpreter state.

@markshannon markshannon changed the title GH-104581: Put eval_breaker back at the start of the interpreter state. GH-104580: Put eval_breaker back at the start of the interpreter state.

Jul 28, 2023

@markshannon

Copy link Copy Markdown

Member Author

@pablogsal you moved this last, AFAICT, so would you mind reviewing?

@pablogsal pablogsal left a comment

edited

Loading

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 3.13 as we have now the offset struct 👍

@markshannon markshannon merged commit a1b6795 into python:main

Jul 28, 2023

@markshannon markshannon deleted the move-eval-breaker-again branch

August 6, 2024 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon @pablogsal @bedevere-bot