GH-104580: Put `eval_breaker` back at the start of the interpreter state. by markshannon · Pull Request #107383 · python/cpython
Conversation
Member
Move the eval_breaker back to the start of interpreter state.
People seem to like moving this field, so I've added comments explaining why it should be the first field in the interpreter state.
bedevere-bot
added
the
awaiting core review
label
markshannon
changed the title
GH-104581: Put
GH-104580: Put eval_breaker back at the start of the interpreter state.eval_breaker back at the start of the interpreter state.
bedevere-bot
mentioned this pull request
markshannon
added
the
skip news
label
markshannon
commented
Jul 28, 2023
markshannon commented
Member Author
@pablogsal you moved this last, AFAICT, so would you mind reviewing?
pablogsal
approved these changes
pablogsal
left a comment
•
edited
Loading
pablogsal
left a comment
•
edited
edited
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for 3.13 as we have now the offset struct 👍
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
markshannon
merged commit
a1b6795
into
python:main
bedevere-bot
removed
the
awaiting merge
label
markshannon
deleted the
move-eval-breaker-again
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment