◐ Shell
clean mode source ↗

gh-105751: Remove obsolete `object` base class in some ctypes tests by tomasr8 · Pull Request #107460 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

ambv

merged 1 commit into

Jul 31, 2023

Conversation

@tomasr8

Some classes in the ctypes tests still explicitly inherit from object which is a relic from Python 2.
Let's remove them. (This is a simple change so I think that a separate issue is not necessary?)

@ambv ambv changed the title ctypes: Remove obsolete object base class in some test cases gh-105751: Remove obsolete object base class in some ctypes tests

Jul 31, 2023

@miss-islington

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.12

@miss-islington

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.11

@tomasr8 tomasr8 deleted the ctypes-remove-object branch

July 31, 2023 13:34

ambv pushed a commit to ambv/cpython that referenced this pull request

Jul 31, 2023 
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>

@bedevere-bot

ambv pushed a commit to ambv/cpython that referenced this pull request

Jul 31, 2023 
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>

@bedevere-bot

ambv added a commit that referenced this pull request

Jul 31, 2023

ambv added a commit that referenced this pull request

Jul 31, 2023

Labels