◐ Shell
clean mode source ↗

gh-105481: combine regen-opcode-targets with regen-opcode to avoid calculating the specialized opcodes in two places by iritkatriel · Pull Request #107540 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented

Aug 1, 2023

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Python/makeopcodetargets.py (which is invoked by make regen-opcode-targets) can be replaced by a few lines added to Tools\build\generate_opcode_h.py, because most of its work is repeated there. This removes a make target and reduces code duplication.

…oid calculating the specialized opcodes in two places

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@iritkatriel iritkatriel merged commit 2bd04d4 into python:main

Aug 1, 2023

@iritkatriel iritkatriel deleted the opcode_targets1 branch

November 13, 2023 15:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon

+1 more reviewer

@AraHaan AraHaan AraHaan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @gvanrossum @AraHaan @bedevere-bot