gh-105481: combine regen-opcode-targets with regen-opcode to avoid calculating the specialized opcodes in two places by iritkatriel · Pull Request #107540 · python/cpython
Conversation
Member
Python/makeopcodetargets.py (which is invoked by make regen-opcode-targets) can be replaced by a few lines added to Tools\build\generate_opcode_h.py, because most of its work is repeated there. This removes a make target and reduces code duplication.
…oid calculating the specialized opcodes in two places
iritkatriel
requested a review
from a team
as a code owner
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting core review
label
blurb-it Bot and others added 2 commits
AraHaan
approved these changes
iritkatriel
requested review from
gvanrossum and
markshannon
gvanrossum
approved these changes
gvanrossum
left a comment
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
iritkatriel
merged commit
2bd04d4
into
python:main
bedevere-bot
removed
the
awaiting merge
label
iritkatriel
deleted the
opcode_targets1
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment