gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py by iritkatriel · Pull Request #107971 · python/cpython
…de_Deopt as part of metadata
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. I've left a couple comments where there might be something further to be done.
(I'm approving under the assumption the comments will be resolved first, one way or another.)
Mostly LGTM. I've left a couple comments where there might be something further to be done.
Thanks. A couple of tests for tracing/instrumentation are failing, I'm still debugging that.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revolution! It's almost here!!
A few nits but no need to wait for a re-review.
| @@ -1617,197 +1616,197 @@ def _prepare_test_cases(): | |||
| Instruction = dis.Instruction | |||
|
|
|||
| expected_opinfo_outer = [ | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is just preposterous. Let's commit to doing this in a different way in a future PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.