◐ Shell
clean mode source ↗

gh-106320: Remove _PyDict_GetItemStringWithError() function by vstinner · Pull Request #108313 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

Aug 22, 2023

Conversation

@vstinner

Remove private _PyDict_GetItemStringWithError() function of the public C API: the new PyDict_GetItemStringRef() can be used instead.

  • Move private _PyDict_GetItemStringWithError() to the internal C API.
  • _testcapi get_code_extra_index() uses PyDict_GetItemStringRef(). Avoid using private functions in _testcapi which tests the public C API.
Remove private _PyDict_GetItemStringWithError() function of the
public C API: the new PyDict_GetItemStringRef() can be used instead.

* Move private _PyDict_GetItemStringWithError() to the internal C API.
* _testcapi get_code_extra_index() uses PyDict_GetItemStringRef().
  Avoid using private functions in _testcapi which tests the public C
  API.

@vstinner

Oh. While all tests passed, "Tests / All required checks pass (pull_request)" job is stuck at Queued — Waiting to run this check :-( The Docs job was skipped.

I close/reopen the PR to re-trigger all CI jobs :-(

Labels

2 participants

@vstinner @bedevere-bot