GH-107603: Clinic: Pass specific attributes to ``print_block()`` by AA-Turner · Pull Request #108581 · python/cpython
Conversation
mypy failure seems unrelated: (Edit: very related!)
GH-107603: Clinic: Only pass
GH-107603: Clinic: Pass specific attributes to includes to print_block()print_block()
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks all for the (incredibly fast) reviews!
A
Oh, looks like you'll need to slightly rework two unit tests in test_clinic.py to get CI passing
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters